Skip to content

docs(review): require a pathway back for every minor-release wire change - #3380

Merged
bokelley merged 3 commits into
mainfrom
bokelley/ladon-version-pathway
Oct 24, 2026
Merged

bokelley merged 3 commits into
mainfrom
bokelley/ladon-version-pathway

Conversation

@bokelley

@bokelley bokelley commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Review-rule half of adcontextprotocol/adcp#8410 for this repo.

  • New mandatory Ladon check (DR-0033): a PR that adds or changes support for a 3.x wire feature must also handle the previous minor release, and test it. The handling is one of: droppable through the projection, a move adapter, a refusal, or the identity-reduction rules.
  • Carve-out to witness-not-translator (DR-0032): version translation in src/lib/adapters/version/ and the server handler is in bounds when every removed or moved field is reported and mutations refuse lossy conversion. Unreported translation is still high.

ai-review.yml ignores LADON.md, so this needs a human review. The DRs are still proposed; this can merge once #3372 lands, or wait for ratification.

🤖 Generated with Claude Code


Open workspace in Conductor

@bokelley bokelley changed the title docs(review): require a pathway back for every 3.x wire change docs(review): require a pathway back for every minor-release wire change Oct 22, 2026
@bokelley
bokelley force-pushed the bokelley/ladon-version-pathway branch from 617dda4 to aa92e1c Compare October 24, 2026 00:33

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon is not auto-reviewing this PR because it modifies the review system itself (LADON.md). A human reviewer should review and merge this PR; Ladon resumes on subsequent PRs once these changes land on main.

bokelley and others added 3 commits October 24, 2026 10:31
Adds the DR-0033 rule to Ladon's mandatory checks and scopes the
witness-not-translator rule's exception for reported version translation
(DR-0032).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@bokelley
bokelley force-pushed the bokelley/ladon-version-pathway branch from aa92e1c to 0a09398 Compare October 24, 2026 10:33

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon is not auto-reviewing this PR because it modifies the review system itself (LADON.md). A human reviewer should review and merge this PR; Ladon resumes on subsequent PRs once these changes land on main.

@bokelley
bokelley merged commit 998dd7a into main Oct 24, 2026
43 of 45 checks passed
@bokelley
bokelley deleted the bokelley/ladon-version-pathway branch October 24, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant